config.def.h: add an option allowwindowops, by default off (secure)

Similar to the xterm AllowWindowOps option, this is an option to allow or
disallow certain (non-interactive) operations that can be insecure or
exploited.

NOTE: xsettitle() is not guarded by this because st does not support printing
the window title. Else this could be exploitable (arbitrary code execution).
Similar problems have been found in the past in other terminal emulators.

The sequence for base64-encoded clipboard copy is now guarded because it allows
a sequence written to the terminal to manipulate the clipboard of the running
user non-interactively, for example:

printf '\x1b]52;0;ZWNobyBoaQ0=\a'
This commit is contained in:
Hiltjo Posthuma
2020-05-30 21:56:18 +02:00
parent 0f8b40652b
commit a2a704492b
3 changed files with 6 additions and 1 deletions

2
st.c
View File

@ -1861,7 +1861,7 @@ strhandle(void)
xsettitle(strescseq.args[1]);
return;
case 52:
if (narg > 2) {
if (narg > 2 && allowwindowops) {
dec = base64dec(strescseq.args[2]);
if (dec) {
xsetsel(dec);