pbentes/slstatus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

do not rely on obsolete feature

Browse Source 
function prototype with unspecified argument is obsolete since c99.

additionally some of these function which don't take any argument were
being called with a `const char *` arg, which is UB.

fix both these issues by declararing ALL the components to accept a
`const char *`, and name the arg "unused" if it's meant to be ignored.
This commit is contained in:
NRK
2022-10-27 02:16:05 +06:00
committed by drkhsh
parent 28ef0b242c
commit 0c2b3e5b5c
13 changed files with 61 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
slstatus.h
View File

@ -6,8 +6,8 @@ const char *battery_state(const char *);
const char *battery_remaining(const char *);
/* cpu */
const char *cpu_freq(void);
const char *cpu_perc(void);
const char *cpu_freq(const char *unused);
const char *cpu_perc(const char *unused);
/* datetime */
const char *datetime(const char *fmt);
@ -19,26 +19,26 @@ const char *disk_total(const char *path);
const char *disk_used(const char *path);
/* entropy */
const char *entropy(void);
const char *entropy(const char *unused);
/* hostname */
const char *hostname(void);
const char *hostname(const char *unused);
/* ip */
const char *ipv4(const char *interface);
const char *ipv6(const char *interface);
/* kernel_release */
const char *kernel_release(void);
const char *kernel_release(const char *unused);
/* keyboard_indicators */
const char *keyboard_indicators(const char *fmt);
/* keymap */
const char *keymap(void);
const char *keymap(const char *unused);
/* load_avg */
const char *load_avg(void);
const char *load_avg(const char *unused);
/* netspeeds */
const char *netspeed_rx(const char *interface);
@ -48,10 +48,10 @@ const char *netspeed_tx(const char *interface);
const char *num_files(const char *path);
/* ram */
const char *ram_free(void);
const char *ram_perc(void);
const char *ram_total(void);
const char *ram_used(void);
const char *ram_free(const char *unused);
const char *ram_perc(const char *unused);
const char *ram_total(const char *unused);
const char *ram_used(const char *unused);
/* run_command */
const char *run_command(const char *cmd);
@ -60,21 +60,21 @@ const char *run_command(const char *cmd);
const char *separator(const char *separator);
/* swap */
const char *swap_free(void);
const char *swap_perc(void);
const char *swap_total(void);
const char *swap_used(void);
const char *swap_free(const char *unused);
const char *swap_perc(const char *unused);
const char *swap_total(const char *unused);
const char *swap_used(const char *unused);
/* temperature */
const char *temp(const char *);
/* uptime */
const char *uptime(void);
const char *uptime(const char *unused);
/* user */
const char *gid(void);
const char *username(void);
const char *uid(void);
const char *gid(const char *unused);
const char *username(const char *unused);
const char *uid(const char *unused);
/* volume */
const char *vol_perc(const char *card);